Handling CloseSpider exception if it has been raised in start_requests() #6148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for issue #3463.
I assume it's not the cleanest approach, so I'm opened for change requests after review.
I was trying to modify the
ExecutionEngine.open_spider
in a way that thestart_requests
's exception would be called inside it. But it looked that it would take too much changes, so a lot of stuff can be broken.Still, I'm opened to any ideas of how to make this change better.