Use "utf-8" instead of "utf8" as the default encoding.

scrapy · Dec 11, 2024 · 63c6244 · 63c6244
1 parent 05f0435
commit 63c6244
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/parsel/selector.py b/parsel/selector.py
@@ -90,7 +90,7 @@ def create_root_node(
     base_url: Optional[str] = None,
     huge_tree: bool = LXML_SUPPORTS_HUGE_TREE,
     body: bytes = b"",
-    encoding: str = "utf8",
+    encoding: str = "utf-8",
 ) -> etree._Element:
     """Create root node for text using given parser class."""
     if not text:
@@ -318,7 +318,7 @@ def _get_root_and_type_from_bytes(
 ) -> Tuple[Any, str]:
     if input_type == "text":
         return body.decode(encoding), input_type
-    if encoding == "utf8":
+    if encoding == "utf-8":
         try:
             data = json.load(BytesIO(body))
         except ValueError:
@@ -445,7 +445,7 @@ def __init__(
         text: Optional[str] = None,
         type: Optional[str] = None,
         body: bytes = b"",
-        encoding: str = "utf8",
+        encoding: str = "utf-8",
         namespaces: Optional[Mapping[str, str]] = None,
         root: Optional[Any] = _NOT_SET,
         base_url: Optional[str] = None,
@@ -518,7 +518,7 @@ def _get_root(
         huge_tree: bool = LXML_SUPPORTS_HUGE_TREE,
         type: Optional[str] = None,
         body: bytes = b"",
-        encoding: str = "utf8",
+        encoding: str = "utf-8",
     ) -> etree._Element:
         return create_root_node(
             text,

diff --git a/tests/test_selector.py b/tests/test_selector.py
@@ -1346,7 +1346,7 @@ def __init__(
         text: Optional[str] = None,
         type: Optional[str] = None,
         body: bytes = b"",
-        encoding: str = "utf8",
+        encoding: str = "utf-8",
         namespaces: Optional[Mapping[str, str]] = None,
         root: Optional[Any] = _NOT_SET,
         base_url: Optional[str] = None,

diff --git a/tests/test_selector_csstranslator.py b/tests/test_selector_csstranslator.py
@@ -227,4 +227,4 @@ def test_pseudoclass_has(self) -> None:
 
 class CSSSelectorTestBytes(CSSSelectorTest):
     def setUp(self) -> None:
-        self.sel = self.sscls(body=bytes(HTMLBODY, encoding="utf8"))
+        self.sel = self.sscls(body=bytes(HTMLBODY, encoding="utf-8"))