-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox env with no dependencies #22
base: master
Are you sure you want to change the base?
Conversation
bd07912
to
f556354
Compare
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
===========================================
- Coverage 100.00% 97.95% -2.05%
===========================================
Files 2 2
Lines 98 98
===========================================
- Hits 98 96 -2
- Misses 0 2 +2
Continue to review full report at Codecov.
|
70c77e5
to
ad70a7d
Compare
Which parts of the coverage drop are unexpected? |
Here's the report for
This is the report for
Those two ☝️ are independent runs, deleting the If the database is not deleted in between runs, the
Those two missing lines are expected, because |
https://github.com/scrapy/itemadapter/pull/22/checks?check_run_id=730122799
On the bright side, this may mean that the upload to Codecov is not the issue here. |
Interesting. Seems like by running |
Instead of using It means some duplication between |
#33 shows a possible approach to work around pytest depending on It does increase the complexity of the tests, though. |
Fixes #10
Two problems with this:
Merging reports does not seem to be working, coverage report shows a 13.9% decrease that is not actually accurate.attrs
is a dependency of pytest, so it gets installed. I tried to mock it but it's tricky, we need to prevent all imports from withinitemadapter
but not those withinpytest
; not sure it's worth it.