Added code snippet to explain how to use splash behind proxy #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 87.7% 87.71% +<.01%
==========================================
Files 42 39 -3
Lines 5539 5519 -20
Branches 758 758
==========================================
- Hits 4858 4841 -17
+ Misses 510 509 -1
+ Partials 171 169 -2
Continue to review full report at Codecov.
|
lucywang000
reviewed
Mar 27, 2018
| @@ -0,0 +1,19 @@ | |||
| function main(splash) | |||
There was a problem hiding this comment.
I think "use-proxy.lua" would be a better name (the convention in the examples/ folder is to use dash-separated file name, not camel case).
| } | ||
| end) | ||
| local url = splash.args.url | ||
| assert(splash:go(url)) |
There was a problem hiding this comment.
It doesn't make sense to create a local variable and only use it once. Simply assert(splash:go(splash.args.url)) would do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.