Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit UI form in new tab #588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gabrii
Copy link

@gabrii gabrii commented Mar 31, 2017

I think this way is better, otherwise the current script gets lost after submit.

@codecov-io
Copy link

Codecov Report

Merging #588 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage    87.7%   87.71%   +<.01%     
==========================================
  Files          42       39       -3     
  Lines        5539     5519      -20     
  Branches      758      758              
==========================================
- Hits         4858     4841      -17     
+ Misses        510      509       -1     
+ Partials      171      169       -2
Impacted Files Coverage Δ
splash/resources.py 88.41% <ø> (ø) ⬆️
splash/har/utils.py 90.37% <0%> (-3.38%) ⬇️
splash/__init__.py 100% <0%> (ø) ⬆️
splash/qtutils.py 78.43% <0%> (ø) ⬆️
splash/har/__init__.py
splash/utils.py
splash/kernel/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78b7a2...6f454f2. Read the comment docs.

@kmike
Copy link
Member

kmike commented Jun 5, 2017

I'm not sure I follow - for me the script is preserved in the editor after submitting. Is it not the case for you? Are there JS error logs in the console?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants