-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser_tab.py #426
base: master
Are you sure you want to change the base?
Conversation
Line:915 Change "user-agent" to "User-Agent"
Current coverage is
|
Hi @Genius001 thanks for the pull request! There are some test failing because they have "user-agent" instead of "User-Agent" hardcoded in them, would you mind fixing that as well? |
Hi, @Youwotma I noticed if change all 'user-agent' to 'User-Agent' in tests/test_execute.py that will cause another problem, And test will failing. The error log https://travis-ci.org/scrapinghub/splash/jobs/118187194#L2146 I could not figure out how to resolve it. But this time I thought whether is it necessary to do this or keep original? If it is necessary, workaround? |
Line: 915
Change "user-agent" to "User-Agent"