Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: New API endpoint _cache_control. Solves #203 #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starrify
Copy link
Member

@starrify starrify commented Nov 19, 2015

Fixes #203

@codecov-io
Copy link

Current coverage is 85.45%

Merging #339 into master will decrease coverage by -0.02% as of 9c34085

@@            master    #339   diff @@
======================================
  Files           40      40       
  Stmts         4655    4675    +20
  Branches       631     638     +7
  Methods          0       0       
======================================
+ Hit           3979    3995    +16
+ Partial        151     150     -1
- Missed         525     530     +5

Review entire Coverage Diff as of 9c34085

Powered by Codecov. Updated on successful CI builds.

@kmike
Copy link
Member

kmike commented Dec 1, 2015

Hey @starrify,

The feature makes sense, but I think it is not good to allow to set these options via HTTP API: they should be set at startup like other global Splash options.

@nramirezuy
Copy link

hey @starrify, was this working properly before? Because right now it seems to be ignoring QSettings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable browser/webkit caching ?
4 participants