Use Proxy-Authorization header on proxy object, not on request object for CONNECT method (https://...) #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienvauchelles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Splash does not correctly handle proxy authentication as specified in RFC2817.
When using the CONNECT method with a proxy, the
Proxy-Authorizationheader is not accessible from the request because it is TLS encrypted. Adding this header to therequestobject doesn't work (see network_manager.py, line 291).For the CONNECT method, the
Proxy-Authorizationheader should be set on the proxy object.This PR resolves the issue.
Thanks.
Fabien.