Add process_spider_output_async() to the spider middleware. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe you can install a newer version of the entrypoint through |
Gallaecio
approved these changes
Dec 27, 2024
wRAR
commented
Dec 27, 2024
| @@ -1,5 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
| import itertools | |||
| from warnings import warn | |||
There was a problem hiding this comment.
This is for the call in HubstorageDownloaderMiddleware.from_crawler(), added in some older change.
wRAR
commented
Dec 27, 2024
| @@ -28,11 +29,22 @@ def process_spider_output(self, response, result, spider): | |||
| parent = self._seen_requests.pop(response.request, None) | |||
| for x in result: | |||
| if isinstance(x, Request): | |||
There was a problem hiding this comment.
Check not extracted because we tentatively decided that as a general pattern for such middlewares we prefer to separate "process_request" and "process_item" logic.
kmike
reviewed
Dec 27, 2024
kmike
approved these changes
Dec 27, 2024
10 tasks
|
I confirmed this works (if the project has an async middleware, there is a warning normally and no warning if this branch is installed explicitly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72.
I wonder how can we test the change on Scrapy Cloud before merging this though?