Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove python 3.7 #219

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: remove python 3.7 #219

merged 2 commits into from
Apr 17, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Apr 16, 2024 •
edited
Loading

Changes

@Gallaecio
Copy link
Member

Maybe we could add the python version requirement to setup.py.

lopuhin
lopuhin approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the cleanups @Rotzbua 👍

@lopuhin lopuhin merged commit 9ccde67 into scrapinghub:master Apr 17, 2024
5 checks passed
@Rotzbua Rotzbua deleted the fix_dep_py37 branch May 1, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@lopuhin lopuhin lopuhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rotzbua @Gallaecio @lopuhin