fix: Add Support for lxml >= 5.2.0 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
changed the title
jayaddison
reviewed
Apr 4, 2024
wRAR
reviewed
Apr 4, 2024
|
Looks like the test failures are related to mf2py, not lxml. Looking into whether we should update the tests (probably) or pin mf2py < 2 (probably not) |
|
mf2py released v2 a few months ago which has a single breaking change: it includes image alts in microdata by default (see changelog in release). The reasoning for this is in this mf2py issue, but TL;DR the image alt has been part of the microformat spec for several years, and not including it was considered deprecated behavior (and now is removed entirely). To accommodate this I've updated the tests, though it's not explicitly related to the lxml update. |
1 task
wRAR
approved these changes
Apr 8, 2024
jayaddison
reviewed
Apr 11, 2024
Co-authored-by: James Addison <[email protected]>
Gallaecio
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lxml 5.1.0 removed _ElementStringResult which we use during dom traversal. This PR attempts to import _ElementStringResult as usual, but falls back to defining it explicitly if the import fails. This fixes #215
I chose to attempt to import first to preserve existing behavior if an older version of lxml is installed.
Additionally, we use the lxml HTML cleaner, which is now in its own separate package. Due to this I've added the optional html_clean package to the requirements.txt. As noted below, this raises a warning if using lxml < 5.2.0, but otherwise doesn't impact older versions.