-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix bad JSON due to unescaped double quotes #126
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 90.24% 90.52% +0.28%
==========================================
Files 13 13
Lines 605 623 +18
Branches 136 137 +1
==========================================
+ Hits 546 564 +18
Misses 52 52
Partials 7 7
Continue to review full report at Codecov.
|
Just found https://github.com/codecobblers/dirtyjson by fast googling. May be it have sense to use it here. |
Using a library would definitely be better. I’m a bit worried about the library not having received changes since 2017, and @scottkmaxwell not being active in GitHub since 2018. On the other hand, there are no open issues or pull requests in the repository, and worse case scenario we could fork the library. I’ll give it a try. |
According to #137 (comment) it won’t work. |
@Kiollpt thanks for checking and @Gallaecio thanks for passing the message |
I'm still around, just busy with my day job. It looks like I am not getting my GitHub notifications in email so I'll fix that now. Feel free to use or fork. If you want to just use dirtyjson, I'll try to be responsive to PRs. |
Fixes #53
If we merge this, we should create a separate issue to handle #53 (comment), which probably requires a custom fallback JSON parser.