Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate server version as same-or-newer instead of strictly equal #8

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Nov 29, 2023

Allow the version to be semver-major compatible with a newer minor
version. This makes it more obvious in which order changes should
be deployed. I.e. first deploy the WordPress plugin update, and then
(optionally, gradually) update package.json in content repos.

This is partially blocking the ability to enforce use of
package-lock.json, because up until now, jQuery Infra ran npm update
as part of builder's webhook handlers, thus bypassing the lock file.

Once that step is removed, the true version is exposed, and thus
content changes would no longer auto-update. We could mandate that
all content repos (and their older version branches) are always using
the latest version, but I'd rather build a bit more tolerance in the
stack.

Ref jquery/infrastructure-puppet#39.
Ref jquery/infrastructure-puppet#38.

index.js Show resolved Hide resolved
@scottgonzalez
Copy link
Owner

Ugh, did you update this right away? It's so annoying that there's no notification for force pushes.

@Krinkle
Copy link
Contributor Author

Krinkle commented Apr 4, 2024

@scottgonzalez It was 2-3 weeks after my comment, 17 Dec. But yeah, it didn't reset the review state even after "resolving" your comment, and pushing a new commit. 🤷

@scottgonzalez scottgonzalez merged commit aec97f2 into scottgonzalez:master Apr 4, 2024
@scottgonzalez
Copy link
Owner

Well it's merged and deployed in v1.0.8 now. Thanks.

@Krinkle Krinkle deleted the tolerate branch April 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants