Add callback for GIF rendering completion #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(fixed somehow 🎉 ) |
Currently createPartyImage returns before the image has fully rendered, this can cause invalid image output when the outputStream is immediately read, especially for larger input images, such as animated GIFs These changes add a callback which is fired when the gif finishes rendering, as defined by the `end` event
selalipop
force-pushed
the
add-completion-callback
branch
from
c08ffdc
to
07fd5d8
Compare
|
Do you have a reproducible case where this occurs? I'm not entirely sure what problem this is fixing. Happy to consider the change! Sorry for not looking at this PR sooner. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
createPartyImagereturns before the image has fully rendered,this can cause invalid image output when the outputStream is immediately
read, especially for larger input images, such as animated GIFs
These changes add a callback which is fired when the gif finishes rendering,
as defined by the
endevent