ENH: stats.kurtosistest: add array API support #20715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
the
array types
mdhaber
commented
May 15, 2024
| @@ -1805,6 +1805,9 @@ def kurtosistest(a, axis=0, nan_policy='propagate', alternative='two-sided'): | |||
| hypothesis [4]_. | |||
|
|
|||
| """ | |||
| xp = array_namespace(a) | |||
| a, axis = _chk_asarray(a, axis, xp=xp) | |||
There was a problem hiding this comment.
For NumPy, _axis_nan_policy decorator takes care of raveling for axis=None. It doesn't right now for array API, so bring back _chk_asarray.
mdhaber
commented
May 15, 2024
Comment on lines
+6216
to
+6221
| x = xp.arange(30.) | ||
| x[29] = NaN | ||
| with np.errstate(all='ignore'): | ||
| res = stats.kurtosistest(x) | ||
| xp_assert_equal(res.statistic, NaN) | ||
| xp_assert_equal(res.pvalue, NaN) |
There was a problem hiding this comment.
Brought this up from below.
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-20544
What does this implement/fix?
Adds array API support to
scipy.stats.kurtosistest.Additional information
Again just blindly converting the relevant parts of the mega-test to array API. Will split it up into separate tests as appropriate after converting
normaltest.