Skip to content

Commit

Permalink
Merge pull request #996 from Vinc0110/vf_deprecation
Browse files Browse the repository at this point in the history
Vector Fitting: Removing deprecated `zeros` attribute
  • Loading branch information
Vinc0110 committed Jan 11, 2024
2 parents af744d7 + 3aff609 commit 74ddb7f
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions skrf/vectorFitting.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,22 +97,6 @@ def __init__(self, network: 'Network'):
self.history_max_sigma = []
self.history_cond_A = []

# legacy getter and setter methods to support deprecated 'zeros' attribute (now correctly called 'residues')
@property
def zeros(self):
"""
**Deprecated**; Please use :attr:`residues` instead.
"""
warnings.warn('Attribute `zeros` is deprecated and will be removed in a future version. Please use the new '
'attribute `residues` instead.', DeprecationWarning, stacklevel=2)
return self.residues

@zeros.setter
def zeros(self, value):
warnings.warn('Attribute `zeros` is deprecated and will be removed in a future version. Please use the new '
'attribute `residues` instead.', DeprecationWarning, stacklevel=2)
self.residues = value

def vector_fit(self, n_poles_real: int = 2, n_poles_cmplx: int = 2, init_pole_spacing: str = 'lin',
parameter_type: str = 's', fit_constant: bool = True, fit_proportional: bool = False) -> None:
"""
Expand Down

0 comments on commit 74ddb7f

Please sign in to comment.