Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for more RNTuple types #1223

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ariostas
Copy link
Collaborator

@ariostas ariostas commented May 23, 2024

This PR adds support for a couple of RNTuple types that are currently not supported, namely std::atomic<T> and std::bitset. I'll make a PR to scikit-hep-testdata to add those, and then set up some tests here.

@ariostas
Copy link
Collaborator Author

There's two more fixes that I'll add to this PR. Currently, if you have an std::variant where one of the types is an empty struct, something goes wrong and it ends up discarding that part of the variant. The other one, is that if you try to read a variant in an invalid state it just doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant