ModuleRunner: do not rethrow caught exceptions

Apparently this is a bad practice. Better to use chaining.
scijava · Aug 5, 2020 · a5993b3 · a5993b3 · imagesc-bot · Aug 5, 2020
1 parent b3fcd90
commit a5993b3
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/main/java/org/scijava/module/ModuleRunner.java b/src/main/java/org/scijava/module/ModuleRunner.java
@@ -124,12 +124,10 @@ public Module call() {
  run();
  }
  catch (final RuntimeException exc) {
- if (log != null) log.error("Module threw exception", exc);
- throw exc;
+ throw new RuntimeException("Module threw exception", exc);
  }
  catch (final Error err) {
- if (log != null) log.error("Module threw error", err);
- throw err;
+ throw new RuntimeException("Module threw error", err);
  }
  return module;
  }