Add topological sorting for dumped views using TSort #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove ~>0.19 constraint on pg gem, which conflicts with ~>1.1 constraint in Gemfile
Upcoming changes like [topological sorting][1] have the potential to write views to `db/schema.rb` in an order that does not respect dependencies. This adds a test to ensure that views in all schemas are both included, and in the correct dependency order. [1]: #398
Co-authored-by: Mykhaylo Sorochan <[email protected]> Co-authored-by: Edward Loveall <[email protected]>
calebhearth
force-pushed
the
new-views-ordering
branch
from
77e52f5
to
cf4217c
Compare
This was referenced May 2, 2024
derekprior
approved these changes
May 3, 2024
|
Should this postgres-specific code live in the postgres adpater? I think this will break the other adapters unless they monkey-patch I've started looking at this for the Oracle adapter and this is the only solution I've come up with. |
|
No I think you're right, this should have been part of an adapter. |
calebhearth
added a commit
that referenced
this pull request
Nov 20, 2024
This is Postgres-specific code, and it shouldn't have been here. #416 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Mykhaylo Sorochan [email protected]
Co-authored-by: Edward Loveall [email protected]