Add Nondeterminism instance for Kleisli/ReaderT #2262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
force-pushed
the
Nondeterminism-Kleisli
branch
from
8f1c2ea
to
f7e4222
Compare
Atry
commented
Dec 30, 2021
| Kleisli { r => | ||
| F.map(F.chooseAny(head(r), tail.map(_(r)))) { | ||
| case (chosen, notChosen) => | ||
| (chosen, notChosen.map(fa => Kleisli(_ => fa))) |
There was a problem hiding this comment.
Kleisli(_ => fa) might be incorrect, because it would discard the any new values.
Shall we change the required function of Nondeterminism to firstCompletedOf as mentioned by #2255
It is hard to implement chooseAny correctly and efficiently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.