Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scalar popover #1596

Merged
merged 4 commits into from
May 3, 2024
Merged

feat: add scalar popover #1596

merged 4 commits into from
May 3, 2024

Conversation

hwkr
Copy link
Contributor

@hwkr hwkr commented May 2, 2024

Little followup PR to #1557 to add popovers and extend scalar floating a little bit for some future usage I foresee with middlewares.

Also I forgot to add the dropdown and floating components to the components export...

Google.Chrome-2024-05-02-14-44-38.mp4

@hwkr hwkr requested review from amritk and geoffgscott May 2, 2024 21:53
@hwkr hwkr requested a review from marclave as a code owner May 2, 2024 21:53
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 21ddaf1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@scalar/components Minor
@scalar/api-client Patch
@scalar/api-reference Patch
@scalar/api-client-react Patch
@scalar/api-reference-react Patch
@scalar/cli Patch
@scalar/express-api-reference Patch
@scalar/fastify-api-reference Patch
@scalar/hono-api-reference Patch
@scalar/mock-server Patch
@scalar/nestjs-api-reference Patch
@scalar/nextjs-api-reference Patch
@scalar/nuxt Patch
@scalar/docusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

relativeci bot commented May 2, 2024

#1273 Bundle Size — 1.9MiB (0%).

21ddaf1(current) vs bb4056f main#1269(baseline)

Warning

Bundle contains 4 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#1273
     Baseline
#1269
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1045 1045
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 158 158
No change  Duplicate Packages 4 4
Bundle size by type  no changes
                 Current
#1273
     Baseline
#1269
No change  JS 1.9MiB 1.9MiB

Bundle analysis reportBranch brynn/add-popoverProject dashboard

Copy link
Member

@amritk amritk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice to have this in a component so we can replace with css anchor when its available!

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @hwkr ! @amritk left a slight comment but can be merged after addressed ✨

@amritk
Copy link
Member

amritk commented May 3, 2024

@marclave @hwkr comment redacted

@marclave marclave merged commit 1c18f77 into main May 3, 2024
9 checks passed
@marclave marclave deleted the brynn/add-popover branch May 3, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants