Add empty dataloader CLI and core sub projects #1726
Conversation
data-loader/cli/build.gradle
Outdated
| spotbugsTest.reports { | ||
| html.enabled = true | ||
| } | ||
| spotbugsTest.excludeFilter = file("${project.rootDir}/gradle/spotbugs-exclude.xml") |
There was a problem hiding this comment.
It's minor but can you add an empty line at the end of the file?
|
@brfrn169 It seems some of the tests are failing but does not really seem related to the content of my PR. Is there something specific I need to be carefull of when pushing content to this repo to avoid this? (unless it actually is caused by my added changes of course.) |
|
@ypeckstadt I re-ran the failed tests, and they were successful. It looks like it's a timing issue. Should we review this again? |
|
@brfrn169 Thank you. I think it's ok to merge. The only new thing I added, after the talk on Slack, is the build.gradle file in the dataloader folder that defines the group name, avoiding the issues with the duplicate |
|
@brfrn169 Just to double check, would it be ok for me to merge after everything is approved and the checks pass? Or better to leave that up to you or Vincent? |
|
@ypeckstadt You can merge after everything is approved and the checks pass. |
Description
To start the migration of moving the Data Loader code to the main repository, we first need to have two new subprojects in the repository. A data loader CLI and core subproject. This PR adds these subprojects.
Related issues and/or PRs
NA
Changes made
Checklist
Additional notes (optional)
I have not added the maven publish and signature code yet in the build.gradle files. I assume it will be a copy of the schema-loader build.gradle file. However, for now, it's better to not add it yet to avoid any publish risks. Will add it via another PR in the future.
Release notes
NA