Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build.mill and build.mill.scala #1543

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Oct 4, 2024

Companion PR of scalameta/metals#6752

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's wait for the metals PR first.

@tgodzik tgodzik merged commit 2647290 into scalameta:main Oct 22, 2024
10 checks passed
@ckipp01
Copy link
Member

ckipp01 commented Oct 24, 2024

Just a note for clients that also have logic to detect the root based off build files, they should also account for this.

@lolgab lolgab deleted the support-mill-suffix branch October 24, 2024 13:32
@lolgab
Copy link
Contributor Author

lolgab commented Oct 24, 2024

Just a note for clients that also have logic to detect the root based off build files, they should also account for this.

I'm not sure I understand. Can you elaborate?

@ckipp01
Copy link
Member

ckipp01 commented Oct 24, 2024

Just a note for clients that also have logic to detect the root based off build files, they should also account for this.

I'm not sure I understand. Can you elaborate?

Sure, and this is more of a note just for client maintainers, not necessarily for you. But in some clients, like Neovim and other terminal based editors, the idea of a "workspace" is sort of artificial. This causes the client to have to have some sort of logic to determine where the workspace root is. For example in nvim-metals we have some logic where we take a pre-set set of patterns that we look for and then we have some logic about traversing down to account for nested builds in different tools, etc. So even though this changes here in Metals, it's good, but this doesn't 100% mean it will actually work in some clients unless they also account for these filetypes.

EDIT: I'm now seeing that this pr is in the VS Code repo, not the actual metals repo... totally my mistake, so just ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants