Fix #3076: Support native Windows toolchain #3866
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+15
to
+19
| typedef ThreadRoutineReturnType(WINAPI *ThreadStartRoutine)(void *); | ||
| #else | ||
| #include <pthread.h> | ||
| typedef void *ThreadRoutineReturnType; | ||
| typedef ThreadRoutineReturnType (*ThreadStartRoutine)(void *); |
There was a problem hiding this comment.
I think we can define a no-op WINAPI when not using Windows and then use a single definition for easier maintenance in the future. Seems like we might need more of them in the glue layer anyway. Alternatively we can create OS_API (or something similar) that on Windows would be equal to WINAPI and no-op otherwise
There was a problem hiding this comment.
Let me check because I think this is only needed for Windows 32-bit which is the default when using the MSVC toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default using MSVC tools compiles for
i686-pc-windows-msvc(32 bit) so calling convention is important.Fix for #3076