Allow extern definitions defined outside extern objects #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal test for usage with non object extern scopes
ekrich
reviewed
Dec 14, 2020
lolgab
reviewed
Dec 15, 2020
| val buf1 = stackalloc[Byte](bufsize) | ||
| val buf2 = stackalloc[Byte](bufsize) | ||
| Ext1.snprintf(buf1, bufsize, c"%s", c"hello") | ||
| assertTrue(string.strcmp(buf1, c"hello") == 0) |
There was a problem hiding this comment.
Did you try to change to assertEquals here (and two lines below)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #897 for extern definitions.
It includes all not yet implemented features from the proposal, that is:
This PR should be followed by changes to #2060 including changes to syntax rules if it would be merged earlier, or should be rebased and adjusted in otherwise.