Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nothing Phone 1 Improvements #5

Open
wants to merge 17 commits into
base: sc7280-6.12.y
Choose a base branch
from
Open

Nothing Phone 1 Improvements #5

wants to merge 17 commits into from
+69,139 −12

Conversation

JIaxyga
Copy link

@JIaxyga JIaxyga commented Oct 24, 2024 •
edited
Loading

What we need to enable comparing with FP5:
CONFIG_NFC_NXP_NCI=m
CONFIG_NFC_NXP_NCI_I2C=m
CONFIG_SND_SOC_TFA9872=m
CONFIG_DRM_PANEL_VISIONOX_RM692E5=m
CONFIG_TOUCHSCREEN_FTS=y

@JIaxyga JIaxyga marked this pull request as ready for review October 24, 2024 21:18
@JIaxyga JIaxyga marked this pull request as draft October 25, 2024 15:37
@JIaxyga JIaxyga marked this pull request as ready for review October 25, 2024 16:12
@z3ntu
Copy link
Member

z3ntu commented Nov 19, 2024

Apart from that comment it looks fine. For panel driver specifically I haven't looked much, I imagine all/most of it is generated? If so, should be fine but upstream will tell you more :)

@z3ntu
Copy link
Member

z3ntu commented Nov 19, 2024

Also if you could retarget on sc7280-6.12.y, would be nice

@JIaxyga
Copy link
Author

JIaxyga commented Nov 20, 2024

Apart from that comment it looks fine. For panel driver specifically I haven't looked much, I imagine all/most of it is generated? If so, should be fine but upstream will tell you more :)

For the most part yes, but the generator still does not use multi functions, which speed up the execution of the *_on function by about 12%. Also, the generator does not add regulators and multi-timings for 60/90Hz.

@JIaxyga
Copy link
Author

JIaxyga commented Nov 20, 2024

Also if you could retarget on sc7280-6.12.y, would be nice

Yes, sure. No problem

@JIaxyga JIaxyga changed the base branch from sc7280-6.11.y to sc7280-6.12.y November 20, 2024 17:47
@JIaxyga
Copy link
Author

JIaxyga commented Nov 20, 2024

oops

JIaxyga and others added 16 commits November 20, 2024 20:48
@JIaxyga
FROMGIT: arm64: dts: qcom: sc7280: Fix PMU nodes for Cortex A55 and A78
2f71ca1 
The SC7280, SM7325, and QCM6490 platforms feature an 8-core setup
consisting of:
- 1x Kryo 670 Prime (Cortex-A78) / Kryo 670 Gold Plus (Cortex-A78)
- 3x Kryo 670 Gold (Cortex-A78)
- 4x Kryo 670 Silver (Cortex-A55)
(The CPU cores in the SC7280 are simply called Kryo, but are
nevertheless based on the same Cortex A78 and A55).

Use the correct compatibility.

Signed-off-by: Danila Tikhonov <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Reviewed-by: Caleb Connolly <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@fekz115 @JIaxyga
FROMGIT: arm64: dts: qcom: sc7280: Add 0x81 Adreno speed bin
a39cb35 
A642L (speedbin 0x81) uses index 4, so this commit sets the fourth bit
for A642L supported opps.

Signed-off-by: Eugene Lepshy <[email protected]>
Signed-off-by: Danila Tikhonov <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@JIaxyga
FROMGIT: dt-bindings: arm: cpus: Add qcom kryo670 compatible
1d4b4c5 
The Qualcomm Snapdragon 778G/778G+/780G/782G uses CPUs named Kryo 670.
Add the compatible string in the documentation.

Signed-off-by: Danila Tikhonov <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@fekz115 @JIaxyga
FROMGIT: arm64: dts: qcom: Add SM7325 device tree
a740a7d 
The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).

It uses the Kryo670.

Signed-off-by: Eugene Lepshy <[email protected]>
Signed-off-by: Danila Tikhonov <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@JIaxyga
FROMGIT: dt-bindings: vendor-prefixes: Add Nothing Technology Limited
dd141d1 
Add entry for Nothing Technology Limited (https://nothing.tech/)

Signed-off-by: Danila Tikhonov <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@JIaxyga
FROMGIT: dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1
d34fc6a 
Nothing Phone 1 (nothing,spacewar) is a smartphone based on the SM7325
SoC.

Signed-off-by: Danila Tikhonov <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@fekz115 @JIaxyga
FROMGIT: arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1
8729bd1 
Add device tree for the Nothing Phone 1 (nothing,spacewar) smartphone
which is based on the SM7325 SoC.

Supported features are, as of now:
* USB & UFS
* Debug UART
* Display via SimpleFB
* Power & volume buttons
* PMIC GLink
* Remoteprocs (ADSP, CDSP, MPSS, WPSS)
* WiFi & Bluetooth
* IPA
* VPU Iris (Venus)
* NFC
* Flash/torch LED
* RTC
* Device-specific thermals
* Various plumbing like regulators, i2c, spi, cci, etc

Signed-off-by: Eugene Lepshy <[email protected]>
Co-developed-by: Danila Tikhonov <[email protected]>
Signed-off-by: Danila Tikhonov <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
@JIaxyga
FROMGIT: dt-bindings: nfc: nxp,nci: Document PN553 compatible
ab9ee14 
The PN553 is another NFC chip from NXP, document the compatible in the
bindings.

Signed-off-by: Danila Tikhonov <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Rob Herring (Arm) <[email protected]>
Link:
https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
@vldly @JIaxyga
ASoC: codecs: add driver for tfa9872
525a693 
Not for upstreaming as is.

Signed-off-by: Vladimyr Lypak <[email protected]>
Signed-off-by: Gabriel David <[email protected]>

ASoC: tfa9872: Remove non_legacy_dai_naming
@JIaxyga
sound: codecs: tfa9872: add tfa9873 support
5393662 
Signed-off-by: Danila Tikhonov <[email protected]>
@fekz115 @JIaxyga
drivers: drm/msm/dsi: Remove protection parameters dsc with bpc != 8
76c9504 
As there is mappings for other bpc cases, this guarding not needed
anymore.

Signed-off-by: Eugene Lepshy <[email protected]>
@JIaxyga
dt-bindings: display: panel: Add Visionox RM692E5
bb7286d 
The Visionox RM692E5 is a 6.55” AMOLED panel used in Nothing Phone (1)
(sm7325-nothing-spacewar).

Signed-off-by: Danila Tikhonov <[email protected]>
@fekz115 @JIaxyga
drm/panel: Add Visionox RM692E5 panel driver
90f7bb4 
Add the driver for Visionox RM692E5 panel support found in Nothing
Phone (1).

Signed-off-by: Eugene Lepshy <[email protected]>
Co-developed-by: Danila Tikhonov <[email protected]>
Signed-off-by: Danila Tikhonov <[email protected]>
@fekz115 @JIaxyga
drivers: input: touchscreen: Import FT touchcscreen driver from DS
bb3ff89 
Changes:
- fts: replace absent const
- fts: migration to use driver as module
- fts: fix remove function return type
- fts: temporary disable any screen handling
- fts: migrate to using of_get_named_gpio
- fts: disable power control for fts for now
- fts: enable pinctrl
See all commits:
https://github.com/mainlining/linux/commits/danila/spacewar

Signed-off-by: Eugene Lepshy <[email protected]>
@JIaxyga
arm64: dts: qcom: sm7325-nothing-spacewar: Add Mi2s sound support
547f560 
Signed-off-by: Danila Tikhonov <[email protected]>
@fekz115 @JIaxyga
arm64: dts: qcom: sm7325-nothing-spacewar: Add panel support
54c5aa8 
Signed-off-by: Eugene Lepshy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3ntu z3ntu z3ntu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JIaxyga @z3ntu @fekz115 @vldly