Use better method to find free port #7083
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mdedetrich, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
mdedetrich
force-pushed
the
use-proper-method-to-find-free-port
branch
10 times, most recently
from
07caa2f
to
fb308d3
Compare
mdedetrich
force-pushed
the
use-proper-method-to-find-free-port
branch
from
fb308d3
to
21ea9f4
Compare
mdedetrich
commented
Dec 2, 2022
| @@ -186,6 +186,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| # test building sbtn on Windows | |||
| sbt "commandProj/testOnly xsbt.IPCSpec" | |||
There was a problem hiding this comment.
This is to make sure the added test runs on Windows
mdedetrich
force-pushed
the
use-proper-method-to-find-free-port
branch
4 times, most recently
from
d22853f
to
9557d2f
Compare
mdedetrich
force-pushed
the
use-proper-method-to-find-free-port
branch
from
9557d2f
to
62c1509
Compare
|
Setting this to draft for now as I don't think its the actual reason behind sbt scripted tests failing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to find random open ports we instead should instead use this technique https://stackoverflow.com/a/2675416 to find free ports which will also work on Windows #7082.