[#6631] Enable launcher script use --sbt-boot #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I broke |
er1c
force-pushed
the
runner-script-sbt-boot
branch
from
85ef0ca
to
b7e03c4
Compare
er1c
commented
Aug 21, 2021
sbt
Outdated
| @@ -620,7 +644,6 @@ map_args () { | |||
| -no-share|--no-share) options=( "${options[@]}" "${noshare_opts[@]}" ) && shift ;; | |||
| -no-global|--no-global) options=( "${options[@]}" "-Dsbt.global.base=$(pwd)/project/.sbtboot" ) && shift ;; | |||
| -ivy|--ivy) require_arg path "$1" "$2" && options=( "${options[@]}" "-Dsbt.ivy.home=$2" ) && shift 2 ;; | |||
| -sbt-boot|--sbt-boot) require_arg path "$1" "$2" && options=( "${options[@]}" "-Dsbt.boot.directory=$2" ) && shift 2 ;; | |||
There was a problem hiding this comment.
I'm not quite sure what the difference between map_args and process_args is, but trying to set the sbt_boot var here didn't work for some reason
er1c
force-pushed
the
runner-script-sbt-boot
branch
3 times, most recently
from
3a17541
to
a3945a2
Compare
er1c
force-pushed
the
runner-script-sbt-boot
branch
from
a3945a2
to
d001588
Compare
er1c
force-pushed
the
runner-script-sbt-boot
branch
from
d001588
to
12eb3d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #6631 to use
--sbt-bootdirectory to downloadsbt-launch.jarorsbtnAlso added some minor
SbtScriptTestoutput cleanup.