Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update module dependencies/requirements #54

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Lightning-
Copy link
Contributor

this updates the module dependencies/requirements to recent versions of stdlib and concat

@saz
Copy link
Owner

saz commented Jun 4, 2024

Thanks for the PR! I'd prefer to not have any versions in the .fixtures.yml. Mind updating your PR?

What's the reason for concat >= 9.0.2?

@Lightning- Lightning- force-pushed the dependency_update branch from 6d82e61 to 5d3c526 Compare June 4, 2024 09:00
@Lightning-
Copy link
Contributor Author

Thanks for the PR! I'd prefer to not have any versions in the .fixtures.yml. Mind updating your PR?

no versions are fine too → updated

What's the reason for concat >= 9.0.2?

concat 9.0.0 is reasonable minimum (compatibility with stdlib 9) and 9.0.1 and 9.0.2 are harmless changes/fixes that everybody should simply apply 😆

@saz
Copy link
Owner

saz commented Jun 4, 2024

concat 9.0.0 is reasonable minimum (compatibility with stdlib 9) and 9.0.1 and 9.0.2 are harmless changes/fixes that everybody should simply apply 😆

The module isn't using any features of stdlib which is specific to v9 or newer. The same is true for concat. I don't see a good reason to raise the lower limit. Newer versions of both concat and stdlib will be used, if possible.

@Lightning- Lightning- force-pushed the dependency_update branch from 5d3c526 to 16f4c0a Compare June 4, 2024 12:00
@Lightning-
Copy link
Contributor Author

well i'd say that it's a good idea to force anything to go beyond stdlib 9 but don't wanna argue about that here; as long as fixtures aren't nailed to ancient anymore i'm good with that 😉

updated commit

@saz saz merged commit 344ea2f into saz:master Jun 4, 2024
18 checks passed
@saz
Copy link
Owner

saz commented Jun 4, 2024

In general, I'm with you to force newer versions, but in some cases, it's just annoying people (and then potentially me 😄 ).

I'm curious, how are you managing modules and their dependencies?

@Lightning-
Copy link
Contributor Author

I'm curious, how are you managing modules and their dependencies?

for the modules i write i'm absolutely merciless → go bleading edge or you possibly can't update 😉.
(but tbh, those modules (around 30) aren't public. at least yet, but i plan to push some of them into the world when i find time to do so).
not that i drop my sword instantly just because any update was released somewhere, but whenever i gotta do something in a module task#1 is to bring anything up-to-date. as well i'm usually pretty fast doing updates for the tools the modules manage (which includes packaging the tools from source instead of using distro-pkgs, if a non-bleading-edge-distro is used).

well ... i just hate code-rot and the spirit of "keep everything compatible as long as possible including preserving old/deprecated/... coding paradigms/patterns etc.". i blame a lazy update spirit for many of the problems in our it-world out there; admins and devs usually don't develop their stuff further just because they're bored, so people imho need to follow. being a linux system engineer and puppet engineer i see it as my job to actively maintain, update, refresh and rework my systems and my codes 😇.

for the modules i just use ... yeah well. trying to keep them as updated as possible unless version conflicts keep me off doing so. of course there's a grace period as people need to invest time/work/sweat/blood 😆. but to take the example of stdlib (and concat): stdlib 9 was released a year ago ... enough time to get the homework done.

of course it's hard to generalize but usually i tend to look forward rather than backward.

@Lightning- Lightning- deleted the dependency_update branch June 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants