Reuse ProcessBuilder from save-cli #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform
sanyavertolet
requested review from
nulls,
Cheshiriks and
0x6675636b796f75676974687562
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform
nulls
reviewed
Apr 10, 2023
core/src/nativeTest/kotlin/com/saveourtool/processbuilder/ProcessBuilderInternalTest.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/saveourtool/processbuilder/utils/FileUtils.kt
Show resolved
Hide resolved
core/src/jsMain/kotlin/com.saveourtool.processbuilder/utils/FileUtils.kt
Outdated
Show resolved
Hide resolved
core/src/jsMain/kotlin/com.saveourtool.processbuilder/NotImplementedInJsError.kt
Outdated
Show resolved
Hide resolved
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform * Downgraded kotest version (5.5.5 -> 5.5.4) as 5.5.5 is not available for macosArm64
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kgevorkyan
reviewed
Apr 10, 2023
core/src/jsMain/kotlin/com.saveourtool.processbuilder/utils/FileUtils.kt
Outdated
Show resolved
Hide resolved
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform * Downgraded kotest version (5.5.5 -> 5.5.4) as 5.5.5 is not available for macosArm64
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform * Downgraded kotest version (5.5.5 -> 5.5.4) as 5.5.5 is not available for macosArm64
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform * Downgraded kotest version (5.5.5 -> 5.5.4) as 5.5.5 is not available for macosArm64
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform * Downgraded kotest version (5.5.5 -> 5.5.4) as 5.5.5 is not available for macosArm64
kgevorkyan
reviewed
Apr 11, 2023
core/src/commonMain/kotlin/com/saveourtool/processbuilder/ProcessBuilder.kt
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/saveourtool/processbuilder/ProcessBuilder.kt
Show resolved
Hide resolved
core/src/nativeMain/kotlin/com.saveourtool.processbuilder/ProcessBuilderInternal.kt
Show resolved
Hide resolved
kgevorkyan
approved these changes
Apr 11, 2023
### What's done: * Moved ProcessBuilder from saveourtool/save-cli to saveourtool/process-builder-multiplatform * Downgraded kotest version (5.5.5 -> 5.5.4) as 5.5.5 is not available for macosArm64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
ProcessBuilderfromsaveourtool/save-clitosaveourtool/process-builder-multiplatform