[open-] fix open-file for - in cmdlogs #2582 #2584
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2582 and #2583, which were bugs I introduced in #2442. The trouble is that the wrong file is tested for being a terminal. When
command | vd
is run in a terminal,duptty()
eventually turnssys.stdin
into a terminal. The right file to test isstdinSource.fptext
.@anjakefala How can I add some tests that run commands in a shell? I'd like to add tests that pipe to vd, like:
cat sample.tsv | vd -
cat sample.tsv | vd -p -
cat sample.tsv | vd -p open-file.vdj
They'll be good for testing the line of code added in this commit, when I submit a patch to make piped data be binary, instead of text.