Implement capture_stderr C-API option
#2862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an embeddable library we should try to play nice with our parents resources. It is therefore desirable to have a way to capture messages on stderr. This makes it easier and safer to use libsass in eg. threaded environments. Core errors (mainly memory allocation problems) and dev/debug data is still printed to stderr directly.
mgreter
force-pushed
the
feature/capture-stderr
branch
from
4f8bdd2 to
071eebe
Compare
Closed
|
Alternate option providing more flexibility for the caller: a warnings callback, which would default to printing the message to stderr? |
|
Thx @xmo-odoo, that is certainly something I wouldn't be opposed to. Ongoing LibSass 4.0 branch (#3135) already fixes the issue by never directly writing to stderr/stdout if not explicitly requested to. But that branch also complicated error reporting a little by introducing (all optional) ANSI colors, Unicode and line wrapping in the output. Going to close this here as work in this area will certainly not land in any pre 4.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an embeddable library we should try to play nice with
our parents resources. It is therefore desirable to have
a way to capture messages on stderr. This makes it easier
and safer to use libsass in eg. threaded environments.
Core errors (mainly memory allocation problems) and
dev/debug data is still printed to stderr directly.
Introduces two new functions to the C-API:
sass_option_set_suppress_stderrsass_context_get_stderr_string