Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for get fine-tuning jobs #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liron-l
Copy link
Contributor

@liron-l liron-l commented Nov 14, 2023

Describe the change
Add missing implementation for GET /fine_tuning/jobs

Describe your solution
Implemented the method as described in the API specification (consistent with other APIs)

Tests
Added UTs and verified against endpoint

Issue: #574

@liron-l
Copy link
Contributor Author

liron-l commented Nov 14, 2023

@sashabaranov will appreciate your review

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (515de02) 98.35% compared to head (b48c278) 98.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   98.35%   98.16%   -0.19%     
==========================================
  Files          24       24              
  Lines        1276     1310      +34     
==========================================
+ Hits         1255     1286      +31     
- Misses         15       17       +2     
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Missing implementation for GET /fine_tuning/jobs
@liron-l
Copy link
Contributor Author

liron-l commented Nov 15, 2023

@sashabaranov will appreciate your review

@liron-l
Copy link
Contributor Author

liron-l commented Nov 16, 2023

@sashabaranov
Can't really verify this code
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant