Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(proxy): add hints for https (nginx) #26

Merged
merged 2 commits into from
Mar 27, 2023
Merged

docs(proxy): add hints for https (nginx) #26

merged 2 commits into from
Mar 27, 2023

Conversation

ryuujo1573
Copy link
Contributor

In cases that HTTPS is forced, we can use the same config, only port & ssl changed.

Browsers will request wss://vite_origin(:443)/ if http host is localhost(:80).

ryuujo1573 and others added 2 commits March 27, 2023 11:28
@ryuujo1573
feat(nginx): add hints for https
f7ad476 
In cases that HTTPS is forced, we can use the same config, only port & ssl changed.

Browsers will request `wss://vite_origin(:443)/` if http host is `localhost(:80)`.
@sapphi-red
chore: cleanup changes
6003ccc
@sapphi-red
Copy link
Owner

Thanks! I updated the PR a bit.

  • proxy_pass needs use vite as a host name because this example is using docker
  • since the upstream is only one, I removed the upstream part to keep it simple

@sapphi-red sapphi-red changed the title feat(nginx): add hints for https feat(proxy): add hints for https (nginx) Mar 27, 2023
@sapphi-red sapphi-red changed the title feat(proxy): add hints for https (nginx) docs(proxy): add hints for https (nginx) Mar 27, 2023
@sapphi-red sapphi-red merged commit b207289 into sapphi-red:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryuujo1573 @sapphi-red