Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(violation.alert): encode support_group label with ~S #7305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArtieReus
Copy link
Contributor

Description

This commit modifies the Helm chart annotations to include the label_replace() function for encoding the support_group label with the ~S. The change impacts the annotations for the Greenhouse dashboard view link, ensuring that the support_group value follows the required encoding format.

Key Changes:

  • Used label_replace() to append ~S to the support_group label in the description annotation.
  • Improved the clarity of variable usage in the Greenhouse dashboard link by encoding support group labels consistently across deployments.

@sapcc-bot
Copy link
Contributor

Failed to validate the Prometheus rules. Details. Readme.

Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label_replace() is a Prometheus function. It needs to be used in the Prometheus expression a few lines above in expr: ....

The interpolation here, as performed by the alertmanager, does not support any templating functions beyond the bare minimum syntax, esp. not any string replacement functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants