Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): start alignment on dialog header #1440

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jordanl17
Copy link
Member

Currently with a long title, the Dialog uses center which means the close button moves down from the top.
Screenshot 2024-10-30 at 00 29 07

Now, these elements are flex-start so the close button is always the same padding from the top of the dialog

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sanity-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:05am
sanity-ui-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:05am

Copy link
Member

@mariuslundgard mariuslundgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🙏

@jordanl17 jordanl17 merged commit 2f6f95e into main Oct 31, 2024
23 checks passed
@jordanl17 jordanl17 deleted the fix-dialog-header-align branch October 31, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants