fix: url path for reference document links #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binoy14
commented
Jul 24, 2023
src/react/comment/PortableText.tsx
Outdated
| @@ -175,17 +175,19 @@ function Link(props: PortableTextMarkComponentProps) { | |||
| const {packageName, exportPath} = params | |||
| const url = value?.['href'] | |||
| const isExternalUrl = isValidUrl(url) | |||
| const href = isExternalUrl ? url : getInternalHref({url, basePath, packageName, exportPath}) | |||
| const path = !isExternalUrl && getInternalHref({url, basePath, packageName, exportPath}) | |||
There was a problem hiding this comment.
Is this better?
Suggested change
| const path = !isExternalUrl && getInternalHref({url, basePath, packageName, exportPath}) | |
| const path = isExternalUrl ? undefined : getInternalHref({url, basePath, packageName, exportPath}) |
There was a problem hiding this comment.
Fair enough - although basePath isn't used in getInternalHref anymore, so should probably remove it.
rexxars
approved these changes
Jul 24, 2023
src/react/comment/PortableText.tsx
Outdated
| @@ -175,17 +175,19 @@ function Link(props: PortableTextMarkComponentProps) { | |||
| const {packageName, exportPath} = params | |||
| const url = value?.['href'] | |||
| const isExternalUrl = isValidUrl(url) | |||
| const href = isExternalUrl ? url : getInternalHref({url, basePath, packageName, exportPath}) | |||
| const path = !isExternalUrl && getInternalHref({url, basePath, packageName, exportPath}) | |||
There was a problem hiding this comment.
Fair enough - although basePath isn't used in getInternalHref anymore, so should probably remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.