Confirm coverage of Vue component #1585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHulme
commented
Feb 16, 2024
app/javascript/scratch/example.vue
Outdated
Comment on lines
10
to
12
| return { | ||
| message: 'Hello, World!', | ||
| } |
There was a problem hiding this comment.
This line should be included in coverage, but is not currently tested
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1585 +/- ##
===========================================
- Coverage 90.82% 86.26% -4.56%
===========================================
Files 376 398 +22
Lines 7268 7654 +386
===========================================
+ Hits 6601 6603 +2
- Misses 667 1051 +384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit 0c421c2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.0% change). View more on Code Climate. |
StephenHulme
added a commit
that referenced
this pull request
Feb 21, 2024
StephenHulme
added a commit
that referenced
this pull request
Feb 21, 2024
build: exclude Vue SFC from coverage stats until #1585 is addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes an investigation in to unexpectedly high code coverage stemming from #1520.
Once this issue has been resolved #1589 can be reverted.
Relates to:
Changes proposed in this pull request
Current reflected test coverage:
Line 11andline 16should be covered (green),line 21should not be covered (red).Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version