Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements #82

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Small improvements #82

merged 8 commits into from
Sep 6, 2024

Conversation

zbrag
Copy link
Contributor

@zbrag zbrag commented Aug 27, 2024

Hey,

we're currently using this implementation ourself, and we ran into some small problems which we fixed in this pullrequest

  1. Is was impossible to use PSR/log of (in this case) whmcs, bu allowing version 1 and 2 as well, we can use is even with older php versions. The functionality doesn't change with this patch, but it allows to use even PHP 7.4 with the api (which is kinda supported by some linux distros)
  2. Getting a quote from the domain api was not processed correctly. It now works as advertised
  3. The account credit code failed when we returned more than one currency. This has also been fixed

I hope you are able to merge this pullrequest without any problems.

nawaik
nawaik previously approved these changes Aug 28, 2024
nawaik
nawaik previously approved these changes Aug 29, 2024
glenn1001
glenn1001 previously approved these changes Aug 30, 2024
@glenn1001
Copy link
Contributor

@zbrag The only thing which stops us from merging this PR is the failing CI.
Can you fix, commit and push the php-cs issues in src/Api/ProvidersApi.php and in src/Api/DomainsApi.php, then we can merge this PR.

@zbrag zbrag dismissed stale reviews from glenn1001 and nawaik via 6641b09 September 5, 2024 13:01
@zbrag
Copy link
Contributor Author

zbrag commented Sep 5, 2024

@zbrag The only thing which stops us from merging this PR is the failing CI. Can you fix, commit and push the php-cs issues in src/Api/ProvidersApi.php and in src/Api/DomainsApi.php, then we can merge this PR.

Sorry about that, it seems the composer.lock I had referenced some old version of the codestyle. I hope this fixes the problems :)

@glenn1001 glenn1001 merged commit 11dd0ea into sandwave-io:master Sep 6, 2024
1 check passed
@zbrag zbrag deleted the whmcs branch September 6, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants