Added DNS zone management options #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
============================================
+ Coverage 97.30% 97.44% +0.14%
- Complexity 624 669 +45
============================================
Files 116 119 +3
Lines 2408 2547 +139
============================================
+ Hits 2343 2482 +139
Misses 65 65 ☔ View full report in Codecov by Sentry. |
glenn1001
approved these changes
Apr 16, 2024
koenhendriks
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these were missing since the introduction of the new DNS Zone management API.
I've reused the DomainZoneRecordCollection and KeyDataCollection and added a new ZoneServiceEnum