Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote response to the appropriate methods #77

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

marcvdm
Copy link
Contributor

@marcvdm marcvdm commented Nov 2, 2023

https://dm.realtimeregister.com/docs/api/quotes

Added the quote responses to the domain methods.

Also make use of php enums instead of custom ones.
This could be reverted to use the internal enums but i thinks we should move them all to the new php enums.

Another thing i changed/added is making use of readonly properties and a public constructor.
This way an object in immutable and can safely be created with named arguments.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (834a68e) 98.77% compared to head (7d38b18) 98.32%.

❗ Current head 7d38b18 differs from pull request most recent head 4b9b51b. Consider uploading reports for the commit 4b9b51b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
- Coverage     98.77%   98.32%   -0.46%     
- Complexity      588      598      +10     
============================================
  Files           111      112       +1     
  Lines          2295     2324      +29     
============================================
+ Hits           2267     2285      +18     
- Misses           28       39      +11     
Files Coverage Δ
src/Api/DomainsApi.php 100.00% <100.00%> (ø)
src/Domain/Billable.php 100.00% <100.00%> (ø)
src/Domain/DomainQuote.php 50.00% <50.00%> (ø)
src/Domain/Quote.php 50.00% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glenn1001 glenn1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcvdm Thank you for the PR, this will be merged to master any moment.
Later this week there will be some small additional changes and afterwards we will create a new release.

@glenn1001 glenn1001 merged commit 44ed13a into sandwave-io:master Jan 17, 2024
1 check passed
@marcvdm marcvdm deleted the fix/quote branch January 17, 2024 13:15
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants