Changed rx and tx callbacks to std::function #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
std::function
rather than function pointers, users can invokemore complex callback functions such as non-static methods via the use of
std::bind
.This is a backwards compatible change as function pointers coerce into
std::function
s. I've verfied as much by compiling and running an existing project and it works without any modifications.I have not updated any documentation as it doesn't explicitly say "function pointer" which would now be wrong, just "function" which could mean
std::function
.