-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] "What's New" Pop-Up #757
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const [pageNum, setPageNum] = useState(1); | ||
const nextPage = () => setPageNum((prev) => prev + 1); | ||
const prevPage = () => setPageNum((prev) => prev - 1); | ||
const renderPage = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this a new component based on what release we want to display.
return ( | ||
<Modal isOpen={isOpen} onClose={onClose} size="4xl" isCentered> | ||
<ModalOverlay /> | ||
<ModalContent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new component for new releases can be a ModalContent
packages/frontend/pages/home.tsx
Outdated
// }, []); | ||
|
||
useEffect(() => { | ||
const existingToken = cookies.get("FeedbackModal JWT"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the cookies token name to something more closely associated
Description
Closes #749
Type of change
Please tick the boxes that best match your changes.
yarn install
yarn dev:migration:run
How Has This Been Tested?
Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.
Checklist: