Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] "What's New" Pop-Up #757

Merged
merged 16 commits into from
Nov 14, 2024
Merged

[FEATURE] "What's New" Pop-Up #757

merged 16 commits into from
Nov 14, 2024

Conversation

ShireenKumar
Copy link
Contributor

@ShireenKumar ShireenKumar commented Oct 20, 2024

Description

  • Added What's New Modal that displays based on Cookies
  • Created pages to display new features
  • Updated icons for header and new header button to show new features
graduate-header-icons in-progress-modal-page searchneu-modal-page

Closes #749

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 1:33am

const [pageNum, setPageNum] = useState(1);
const nextPage = () => setPageNum((prev) => prev + 1);
const prevPage = () => setPageNum((prev) => prev - 1);
const renderPage = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this a new component based on what release we want to display.

return (
<Modal isOpen={isOpen} onClose={onClose} size="4xl" isCentered>
<ModalOverlay />
<ModalContent>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new component for new releases can be a ModalContent

// }, []);

useEffect(() => {
const existingToken = cookies.get("FeedbackModal JWT");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the cookies token name to something more closely associated

@ShireenKumar ShireenKumar merged commit 8572da4 into main Nov 14, 2024
7 checks passed
@ShireenKumar ShireenKumar deleted the whats-new-modal branch November 14, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] "What's New" Pop-up
2 participants