Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in progress display for a section once it's in progress #756

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

23langloisj
Copy link
Contributor

Description

I added a new SidebarValidationStatus that marks sections, concentrations, and NUPaths as 'in progress,' using a dedicated icon whenever any of them are in progress.

Closes # (751)

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

via inspection

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

Screenshot 2024-10-17 at 6 18 21 PM Screenshot 2024-10-17 at 6 22 14 PM Screenshot 2024-10-17 at 6 22 38 PM

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

@23langloisj 23langloisj self-assigned this Oct 17, 2024
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 3:33pm

@23langloisj 23langloisj requested a review from KobeZ123 October 17, 2024 22:23
package.json Outdated
@@ -41,6 +41,7 @@
"@nestjs/axios": "^3.0.2",
"@nestjs/terminus": "^10.2.2",
"@nestjs/throttler": "^5.0.1",
"chakra-ui-ionicons": "^0.3.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this end up being utilized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, just got rid of it

Copy link
Contributor

@KobeZ123 KobeZ123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@23langloisj 23langloisj merged commit 3438e3c into main Oct 29, 2024
7 checks passed
@23langloisj 23langloisj deleted the section-in-progress-feature branch October 29, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants