-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Viewer
plugin support
#183
Merged
mathewjordan
merged 30 commits into
samvera-labs:main
from
wykhuh:feature/clippings-clover
May 28, 2024
Merged
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
baf3c4a
update .gitignore
wykhuh 15ac0ec
add plugins to Viewer
wykhuh eb03da7
refactor getAnnotationResources to handle external annotation pages
wykhuh 98fdeae
refactor parseAnnotationTarget to handle FragmentSelector
wykhuh a4a3f96
add ignoreAnnotationOverlaysLabels to not add overlays to annotations
wykhuh 2836f71
add infomation panel to plugins
wykhuh 0528f09
export annotation and helpers
wykhuh 366e081
fix - add try catch to getAnnotationResources
wykhuh 451dd05
refactor plugin component and info panel to have same props
wykhuh 1088534
add Plugin typescript type
wykhuh e951790
add menu section to plugins props
wykhuh 6350c7d
refactor plugin info panel so the panel can be shown or hidden
wykhuh d83498b
update build process to include annotation and openseadragon helpers
wykhuh d535797
update types for plugins
wykhuh 04fb1b2
improve error handling - add console.log, ErrorFallback, try...catch
wykhuh b20633f
fix - handle cases when annotation have no body for formatPluginAnnot…
wykhuh a421b1b
update gitignore
wykhuh 6331e93
remove annotations from plugins
wykhuh c769703
add imageViewer property to plugin config
wykhuh dd2e097
fix linting issues
wykhuh 8148cac
Update package-lock.json
wykhuh 5f44adb
delete unneeded code
wykhuh 3c450e9
reorganize exporting as helper functions
wykhuh 70980ed
rename imageViewer.menu to imageViewer.controls
wykhuh 1ac9988
update PluginInformationPanel type
wykhuh 63300f8
simplify props passed to plugin components
wykhuh 9efd5ea
reorganize exporting as helper functions
wykhuh 6ea8b8d
add documentation for plugins
wykhuh 448c383
add plugins to viewer docs
wykhuh 2be1c8c
consolidate helpers export
wykhuh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,4 +17,8 @@ html/ | |
|
||
# VSCode | ||
.vscode/ | ||
|
||
dist/tsconfig.tsbuildinfo | ||
tmp | ||
.env.local | ||
tsconfig.tsbuildinfo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,19 @@ import Primitives from "./primitives"; | |
import Scroll from "./scroll"; | ||
import Slider from "./slider"; | ||
import Viewer from "./viewer"; | ||
import { | ||
parseAnnotationTarget, | ||
} from "./annotation-helpers"; | ||
import { createOpenSeadragonRect } from "./openseadragon-helpers"; | ||
|
||
export { Image, Primitives, Scroll, Slider, Viewer }; | ||
export { | ||
Image, | ||
Primitives, | ||
Scroll, | ||
Slider, | ||
Viewer, | ||
parseAnnotationTarget, | ||
createOpenSeadragonRect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, maybe we work to consolidate at some point? Perhaps if this reaches a count of three. |
||
}; | ||
|
||
export default Viewer; | ||
export default Viewer; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might bloat over time. I wonder if we should try to consolidate all helpers under a single export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consolidated the helpers in a single export