Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node imports breaking #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

fix: node imports breaking #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Transform/HTML.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Sandbox HTML elements
const sandbox = document.implementation.createHTMLDocument('sandbox')

function _getSandboxSafely() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this re-use the same sandbox instance?

const sandbox = document.implementation.createHTMLDocument('sandbox')
return sandbox
}

interface Storage {
tagName: string
Expand Down Expand Up @@ -39,7 +43,9 @@ export default {
},
fromSerializable(data: Storage) {
try {
const element = sandbox.createElement(data.tagName) as HTMLElement
const element = _getSandboxSafely().createElement(
data.tagName
) as HTMLElement
element.innerHTML = data.innerHTML
for (let attribute of Object.keys(data.attributes)) {
try {
Expand Down