Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Support excluded html tag attributes in bbcode formats with false #808

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

live627
Copy link
Collaborator

@live627 live627 commented Mar 6, 2021

No description provided.

@live627
Copy link
Collaborator Author

live627 commented Mar 6, 2021

I notice that this function assumes that returning false short circuits utilis.each, similar to dom.traverse. Only... it doesn't. Was that an oversight or was each()never intended to short circuit?

@live627
Copy link
Collaborator Author

live627 commented Mar 7, 2021

Digging deeper to answer my own question, it seems that the code in question is a holdover from back when jQuery was used. I'll need to test it to see how it breaks things.

@live627 live627 marked this pull request as draft March 8, 2021 08:10
@live627
Copy link
Collaborator Author

live627 commented Mar 8, 2021

I'm converting this one to a draft for now until I can write up a bunch of unit tests for the possibility of compound tag matching.

@live627
Copy link
Collaborator Author

live627 commented Mar 20, 2021

Before i look into writing some tests for this, what are your thoughts @samclarke

@samclarke
Copy link
Owner

Looks good, would be useful to have. It does look like it would change the behaviour of false in matching but as only null is documented that should be fine.

@live627
Copy link
Collaborator Author

live627 commented Apr 14, 2021

I actually didn't think of that. I'm going to set this to target v4.0.0 because of the BC break. Might be silly since it is undocumented. And there may be a chance that someone might be doing it that way.

@live627 live627 added this to the v4.0.0 milestone Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants