Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: Bump golangci-lint to v1.53.3 #288

Merged
merged 1 commit into from
Aug 23, 2023
Merged

hack: Bump golangci-lint to v1.53.3 #288

merged 1 commit into from
Aug 23, 2023

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Feb 23, 2023 •
edited

depends on #313

@anoopcs9 anoopcs9 force-pushed the bump-golanci-lint-1.51.2 branch 5 times, most recently from dca7434 to 8429483 Compare February 23, 2023 06:32
@anoopcs9
Copy link
Collaborator Author

Go 1.19 is a requirement here.

obnoxxx
obnoxxx previously requested changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?

after putting this straight, I think we can move the PR out of draft status ...

@anoopcs9
Copy link
Collaborator Author

@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?

Actual change updates it to v1.51.2. Commit message is wrong here.

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Jul 18, 2023

@anoopcs9 wrote:

@obnoxxx wrote:

@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?

Actual change updates it to v1.51.2. Commit message is wrong here.

Got it, commit looks good. thanks for clarifying!

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

is this the reason for some ci checks failing?

@anoopcs9
Copy link
Collaborator Author

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

is this the reason for some ci checks failing?

Yes.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Jul 25, 2023

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

is this the reason for some ci checks failing?

Yes.

@anoopcs9 , I think if you move this out of draft, we can get it merged and take the next step to update the go version

@obnoxxx
Copy link
Collaborator

obnoxxx commented Jul 27, 2023

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jul 27, 2023

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 requested a review from obnoxxx July 31, 2023 10:01
@anoopcs9 anoopcs9 marked this pull request as ready for review July 31, 2023 10:02
@anoopcs9 anoopcs9 dismissed obnoxxx’s stale review July 31, 2023 10:02

Fixed and updated

@mergify mergify bot added the priority-review This PR deserves a look label Aug 15, 2023
@phlogistonjohn phlogistonjohn removed the priority-review This PR deserves a look label Aug 15, 2023
@phlogistonjohn
Copy link
Collaborator

Removed priority-review label because this depends on #313

@anoopcs9 anoopcs9 changed the title hack: Bump golangci-lint to v1.51.2 hack: Bump golangci-lint to v1.53.3 Aug 16, 2023
@dpulls
Copy link

dpulls bot commented Aug 21, 2023

🎉 All dependencies have been resolved !

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 21, 2023

@Mergifyio rebase

@anoopcs9 @obnoxxx
hack: Bump golang-ci-lint to v1.53.3
956cb0e 
* Removes already deprecated[1] linter varcheck
* Depguard now expects a list of allow/deny list and default rule is to
  allow only std lib in all files[2]. Therefore disable the linter.

[1] https://golangci-lint.run/product/roadmap/#v1490
[2] golangci/golangci-lint#3877 (comment)

Signed-off-by: Anoop C S <[email protected]>
@mergify
Copy link

mergify bot commented Aug 21, 2023

rebase

✅ Branch has been successfully rebased

phlogistonjohn
phlogistonjohn approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update seems to be required in order to use Go 1.20 or later. I tried it out locally and the changes LGTM.

@phlogistonjohn phlogistonjohn mentioned this pull request Aug 21, 2023
Merged
@anoopcs9
Copy link
Collaborator Author

/retest centos-ci/sink-clustered/mini-k8s-latest

@anoopcs9 anoopcs9 requested a review from synarete August 22, 2023 11:30
synarete
synarete approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d448034 into samba-in-kubernetes:master Aug 23, 2023
13 checks passed
@mergify mergify bot added the priority-review This PR deserves a look label Sep 7, 2023
@anoopcs9 anoopcs9 deleted the bump-golanci-lint-1.51.2 branch November 30, 2023 05:54
@anoopcs9 anoopcs9 mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synarete synarete synarete approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees
No one assigned
Labels
priority-review This PR deserves a look
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anoopcs9 @obnoxxx @phlogistonjohn @synarete