Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/server: make it easier to do custom package builds #181

Merged

Conversation

phlogistonjohn
Copy link
Collaborator

Creating a custom "devbuilds" container with custom ceph packages and/or custom samba packages was somewhat annoying. Tweak the install-packages.sh to try and make it slightly easier to do one of these builds.

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shellcheck fails in the CI. please fix

@phlogistonjohn phlogistonjohn force-pushed the jjm-easier-custom-pkgs branch 2 times, most recently from 979afaf to 7c050d0 Compare September 23, 2024 13:50
Creating a custom "devbuilds" container with custom ceph packages and/or
custom samba packages was somewhat annoying. Tweak the
install-packages.sh to try and make it slightly easier to do one of
these builds.

Signed-off-by: John Mulligan <[email protected]>
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obnoxxx obnoxxx merged commit a5244a3 into samba-in-kubernetes:master Sep 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants