Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURRENT_TIMESTAMP instead of NOW() (redshift support) #766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CURRENT_TIMESTAMP instead of NOW() (redshift support) #766

wants to merge 1 commit into from

Conversation

holmok
Copy link

@holmok holmok commented Mar 25, 2021

  • update insert into migrations table to use CURRENT_TIMESTAMP instead of NOW() to better support redshift.

with this and turning off locks (and dealing with the issues creating the migration table, that is another pull request) this makes migrations work in redshift and postgres.

@Shinigami92 Shinigami92 requested a review from goce-cz March 25, 2021 20:47
@Shinigami92 Shinigami92 added old-label enhancement Functionality that enhances existing features needs triage Impact of this request has to be valuated labels Mar 25, 2021
@littlewhywhat littlewhywhat mentioned this pull request May 31, 2021
Open
@littlewhywhat
Copy link
Contributor

hi! thanks for the investigation!

TODO:

  • add test for redshift
  • fix migration table creation

@littlewhywhat
Copy link
Contributor

solves #767

@littlewhywhat littlewhywhat linked an issue Jun 13, 2021 that may be closed by this pull request
Support for AWS Redshift #767
Open
@Shinigami92 Shinigami92 added c: bug Something isn't working needs rebase There is a merge conflict and removed old-label enhancement Functionality that enhances existing features needs triage Impact of this request has to be valuated labels Apr 5, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 5, 2024
@Shinigami92 Shinigami92 requested review from Shinigami92 and removed request for goce-cz April 5, 2024 22:43
@Shinigami92
Copy link
Collaborator

@holmok Could you pls rebase so we can see the PR running against the newest tests/CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92 Shinigami92 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@holmok holmok

Labels
c: bug Something isn't working needs rebase There is a merge conflict
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

Support for AWS Redshift
3 participants
@holmok @littlewhywhat @Shinigami92